Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for graphql nested syntax #58

Open
Janpot opened this issue Sep 19, 2018 · 5 comments
Open

Add support for graphql nested syntax #58

Janpot opened this issue Sep 19, 2018 · 5 comments

Comments

@Janpot
Copy link

Janpot commented Sep 19, 2018

As title says 馃檪
I'd say graphql tagged templates are quite common in javascript code

@blake-regalia
Copy link
Collaborator

Sure! The problem though is that as of now there only seems to be one GraphQL syntax and the scopes that it creates look terrible in our color schemes, we actually have this problem with a few other syntaxes but this one in particular is really ugly:
screen shot 2018-09-19 at 8 11 38 am

I would suggest we'd first need to make a bit of effort to add each scope to (at least) one of the color schemes (likely excelsior since this is the one that supports nested syntaxes right now).

@Janpot
Copy link
Author

Janpot commented Sep 20, 2018

@blake-regalia I also just realised I often use lua in javascript for scripting with redis. Do you think that would be valuable target as well for nested syntax?

@blake-regalia
Copy link
Collaborator

@Janpot absolutely. Lua syntax comes with ST3 and their scopes tend to look more natural in the color scheme so that should be no problem.

@blake-regalia
Copy link
Collaborator

@Janpot v1.8.0

@blake-regalia
Copy link
Collaborator

Should also add highlighting support for template tag gql from https://github.com/apollographql/graphql-tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants