Removes string-key requirement; uses ToPropertyKey to coerce keys. Addresses #5. #10
Conversation
| } | ||
|
|
||
| // Consistency with Map: object need not be technically iterable: | ||
| // Consistency with Map: contract is that entry has "0" and "1" keys, not | ||
| // that it is an array or iterable. | ||
|
|
||
| const { 0: key, 1: val } = pair; |
There was a problem hiding this comment.
Shouldn’t this throw if the array length isn’t 2, and if pair isn’t an array?
There was a problem hiding this comment.
I followed the contract used by the Map constructor. Although all intrinsic APIs that yield entries do so as 2-member arrays, Map is the only existing consumer of them, and all it requires is that each member is an object — not even that the keys are actually present.
new Map([ {0: 'foo', 1: 'bar'}, { 1: 'baz' } ]);
// Map(2) {"foo" => "bar", undefined => "baz"}Check out step 9 in 23.1.1.1 (Map Constructor)
(FWIW, this surprised me! But it seemed better not to introduce an inconsistency here.)
There was a problem hiding this comment.
lol, agree to be consistent.
We might want to put the “extract a list of key/value from the entry” logic in an abstract operation so that both this and Map can share it.
Follow up on changes discussed in #5 and also addresses comments about polyfill implementation in PR #8.
@ljharb, @zloirock