Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reverse instead of hardcoded urls #130

Closed
remik opened this issue Jan 1, 2016 · 4 comments
Closed

Use reverse instead of hardcoded urls #130

remik opened this issue Jan 1, 2016 · 4 comments
Labels
Cleanup

Comments

@remik
Copy link
Collaborator

remik commented Jan 1, 2016

In many places we are using hardcoded urls (especially in tests) eg. /admin/pages/page/add/
We should use reverse function so we don't need update this urls if someone (eg. Django Core) change it.
I Django 1.8 was a change for details page so I update a lot places but few still left.
@remik remik added the Cleanup label Jan 1, 2016
@batiste
Copy link
Owner

batiste commented Jan 19, 2016

Would you provide a more detailed description of what needs to be done here? I might have time to work on that soon.

@remik
Copy link
Collaborator Author

remik commented Jan 19, 2016

Updated.

@batiste
Copy link
Owner

batiste commented Jan 20, 2016

I have worked on it here: 1a26f0a

Is it satisfying?

@remik
Copy link
Collaborator Author

remik commented Jan 20, 2016

Yes. Thanks!

@remik remik closed this as completed Jan 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@batiste @remik