-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract the Kotlin Mutliplatform version to a seperate repository #42
Comments
Any updates on this? |
wa3laikum alsalam, if we keep it in the same repo, we could switch to having the main branch be the kmp branch, which would then have a link to the old branch. |
I would say take the option with the least ongoing maintenance. We can update documentation to make it easier to find if that is a problem. |
I agree with @ahmedre, maintaining both the Java and Kotlin libraries is generally repeated work since the Kotlin version can work perfectly with Java (on the JVM). |
Assalomu alaykum! I think it's better to use the |
wa3laikum alsalam - |
salam 3alaikum, |
Jazakallah brother, that's the best way forward. |
waiyyakum! |
Asslamu Alaikum! I just came across this library through one @ahmedre's talks, yet had a hard time finding it here (there's nothing about it in the main Adhan repo), because it's a branch in this repo.
I guess it would be better if it was separated into its own library, simply called adhan-kotlin (many people may just want to use the Kotlin version on Android without caring for KMP, so this name would make more sense for them).
Thanks!
The text was updated successfully, but these errors were encountered: