Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About sampling #4

Closed
ruizhaogit opened this issue Apr 24, 2017 · 2 comments
Closed

About sampling #4

ruizhaogit opened this issue Apr 24, 2017 · 2 comments

Comments

@ruizhaogit
Copy link

ruizhaogit commented Apr 24, 2017

Hi,

In your code here model.lua, shouldn't the decoder first couple with the encoder, so the sampling could also conditioned on the image features and the previous conversions?

It seems to me that, the sampling is only based on the word in the previous time-step, without the knowledge of the image features and so on.

Best,
Rui

@abhshkdz
Copy link
Member

Coupling is already taken care of here: model.lua#L385, model.lua#L225.

@ruizhaogit
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants