Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for SVG and EOT formats #28

Closed
firegurafiku opened this issue Mar 15, 2017 · 3 comments · Fixed by #29
Closed

Support for SVG and EOT formats #28

firegurafiku opened this issue Mar 15, 2017 · 3 comments · Fixed by #29

Comments

@firegurafiku
Copy link
Contributor

Hi, guys.

Shouldn't the plugin support for EOT and SVG formats as well? I'm very occasionally do something web-related, so I'm not sure if these formats are still relevant to the world, but Google WebFonts seems to provide source files for them as well.

For example, if I navigate to https://fonts.googleapis.com/css?family=PT+Serif with custom User-Agent, I get the following results:

/** User-Agent: Mozilla/5.0 (iPhone; U; CPU iPhone OS 3_0 like Mac OS X; en-us)
    AppleWebKit/528.18 (KHTML, like Gecko) Version/4.0 Mobile/7A341 Safari/528.16 */
@font-face {
  font-family: 'PT Serif';
  font-style: normal;
  font-weight: 400;
  src: local('PT Serif'), local('PTSerif-Regular'), url(...) format('svg');
}

/* User-Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1) */
@font-face {
  font-family: 'PT Serif';
  font-style: normal;
  font-weight: 400;
  src: url(...);
}

I've cut original long URLs from the above output to get rid of horizontal scrolling, but here they are:

In #18 @michaelmior wrote that it would be relatively easy to incorporate support for other formats given that their User-Agents are known.

@battlesnake
Copy link
Owner

Sure, I've been waiting forever for someone to send a pull-request which implements this.

@firegurafiku
Copy link
Contributor Author

@battlesnake

Gimme time until the next sunset, MSK. :)

@battlesnake
Copy link
Owner

Great! :) I get a lot of feature requests and very few pull requests on this repository!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants