Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please provide error message if user inputs any other file extension other than .txt #1

Closed
saminarp opened this issue Sep 16, 2022 · 2 comments
Closed

Please provide error message if user inputs any other file extension other than .txt #1

saminarp opened this issue Sep 16, 2022 · 2 comments
Assignees
@batunpc

Comments

@saminarp
Copy link
Contributor

If the input file is not .txt, you could display a message saying the raw data files other than .txt format is not supported under the current version. Currently, it generates no output if provided with any other file extensions. This might confuse the user or leave them wondering what went wrong.
Overall great work!
@batunpc
Copy link
Owner

batunpc commented Sep 16, 2022

Thank you! It's nice catch.. I will debug it soon

@batunpc batunpc self-assigned this Sep 16, 2022
@batunpc
Copy link
Owner

batunpc commented Sep 16, 2022

CleanShot 2022-09-16 at 17 51 23@2x

Now I provide such error message if any other extension than txt file given. Although the empty dist folder still gets created. This is something I need to look in long run

@batunpc batunpc closed this as completed Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@batunpc batunpc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@batunpc @saminarp