Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add kwargs parsing #13

Merged
merged 4 commits into from Sep 8, 2020
Merged

Conversation

adriencaccia
Copy link
Contributor

@adriencaccia adriencaccia commented Sep 7, 2020

This PR is implementing solution 2 of #12.

@bauerji like I said in the issue I already implemented a solution, so this is the PR.

I am, of course, still open to discuss the different solutions !

@bauerji
Copy link
Owner

bauerji commented Sep 8, 2020

It looks neat, thank You. Could You please remove .vscode directory and also modify README.md file to include feature You created?

@adriencaccia
Copy link
Contributor Author

It looks neat, thank You. Could You please remove .vscode directory and also modify README.md file to include feature You created?

No problem for the README.md
Do you mind if instead I add .vscode to .gitignore ?

@bauerji
Copy link
Owner

bauerji commented Sep 8, 2020

It looks neat, thank You. Could You please remove .vscode directory and also modify README.md file to include feature You created?

No problem for the README.md
Do you mind if instead I add .vscode to .gitignore ?

Of course, add it to .gitignore. The directory should be deleted as well.

@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bauerji bauerji merged commit 71df60c into bauerji:master Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants