allow custom error responses to be generated #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to figure out how to test for a feature using the flask config object as a parameter, I couldn't find a test for this feature flag being used, so I went ahead and added one.
|
This is really a great change. I’ve actually been trying to work around this same issue and this would solve my needs. @bauerji could we get this reviewed and in a release? |
bauerji
reviewed
Aug 28, 2022
By defining a new config value that flask_pydantic looks for (FLASK_PYDANTIC_VALIDATION_ERROR_RAISE), we can support raising an exception when we have a validation error. If that is set and the exception is raised, by default, Flask will respond with a 500 error. However, by coupling that feature with `Flask.register_error_handler`, the user can catch the thrown exception and return whatever custom error response the user wishes. Fixes bauerji#45.
jcreekmore
force-pushed
the
exceptional
branch
from
124142e
to
ad0d8ac
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@bauerji is there something else you are looking for on this? |
|
Thank you @jcreekmore, released in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defining a new config value that flask_pydantic looks for
(FLASK_PYDANTIC_VALIDATION_ERROR_RAISE), we can support raising an
exception when we have a validation error. If that is set and the
exception is raised, by default, Flask will respond with a 500 error.
However, by coupling that feature with
Flask.register_error_handler,the user can catch the thrown exception and return whatever custom error
response the user wishes. Fixes #45.