-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for the wavedrom CLI #23
Comments
Hi, just checking in: did you make any progress on this? I'm trying to assess if it makes sense for me start the implementation from scratch or wait for a PR from your side. In case you're swamped at the moment, could I build upon your current work? |
See #27. |
@bradleyharden Could I ask you to test alfa release 3.0.0a1? The plugin will now default to the use of wavedrom-cli instead of wavedrompy, so shouldn't require any configuration changes on your side. |
@wifasoi In case this is of interest to the SpinalHDL project, could you test it as well? |
@bavovanachte, sure I'll try it out this weekend |
@bavovanachte, I had already installed sphinx-wavedrom with Everything seems to have worked just fine, without any modification on my end. I had already set However, note that I only have one reST file and one wavedrom image in my test repository. I didn't want to create anymore until I was more certain of how I should implement it. |
Thanks for checking! As your test setup is a bit limited, I'll run some more tests on different projects to verify |
Officially release in https://github.com/bavovanachte/sphinx-wavedrom/releases/tag/3.0.0. |
As mentioned in #22, it would be nice to have full control over the rendered image, as if it were inserted with an image directive. Unfortunately, this is not possible with wavedrom's current implementation of live-rendering.
wavedrompy
is a workaround, but it has become out of date. Instead, we can provide support for the wavedrom CLI. We can use it to generate images locally and insert them as we do with images fromwavedrompy
.My plan is to make this completely opt-in. Users will need to install the wavedrom CLI themselves and make sure it is available on the PATH. I will add another configuration option to enable the CLI instead of the existing
wavedrompy
.I already have a working prototype of this that I created for my own use. I need to clean it up, add some error checking and add the configuration variable.
The text was updated successfully, but these errors were encountered: