Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the wavedrom CLI #23

Closed
bradleyharden opened this issue May 15, 2020 · 8 comments
Closed

Add support for the wavedrom CLI #23

bradleyharden opened this issue May 15, 2020 · 8 comments
Milestone

Comments

@bradleyharden
Copy link

As mentioned in #22, it would be nice to have full control over the rendered image, as if it were inserted with an image directive. Unfortunately, this is not possible with wavedrom's current implementation of live-rendering. wavedrompy is a workaround, but it has become out of date. Instead, we can provide support for the wavedrom CLI. We can use it to generate images locally and insert them as we do with images from wavedrompy.

My plan is to make this completely opt-in. Users will need to install the wavedrom CLI themselves and make sure it is available on the PATH. I will add another configuration option to enable the CLI instead of the existing wavedrompy.

I already have a working prototype of this that I created for my own use. I need to clean it up, add some error checking and add the configuration variable.

@bavovanachte
Copy link
Owner

Hi, just checking in: did you make any progress on this? I'm trying to assess if it makes sense for me start the implementation from scratch or wait for a PR from your side. In case you're swamped at the moment, could I build upon your current work?

@bradleyharden
Copy link
Author

See #27.

@bavovanachte bavovanachte added this to the 3.0.0 milestone Aug 28, 2020
@bavovanachte
Copy link
Owner

@bradleyharden Could I ask you to test alfa release 3.0.0a1? The plugin will now default to the use of wavedrom-cli instead of wavedrompy, so shouldn't require any configuration changes on your side.

@bavovanachte
Copy link
Owner

@wifasoi In case this is of interest to the SpinalHDL project, could you test it as well?

@bradleyharden
Copy link
Author

@bavovanachte, sure I'll try it out this weekend

@bradleyharden
Copy link
Author

@bavovanachte, I had already installed sphinx-wavedrom with pip install -e, so I just updated the repository to master. Let me know if you wanted me to test installing from PyPI as well.

Everything seems to have worked just fine, without any modification on my end. I had already set wavedrom_html_jsinline = False, so I just re-ran my Sphinx build. The output looks the same.

However, note that I only have one reST file and one wavedrom image in my test repository. I didn't want to create anymore until I was more certain of how I should implement it.

@bavovanachte
Copy link
Owner

Thanks for checking! As your test setup is a bit limited, I'll run some more tests on different projects to verify

@bavovanachte
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
sphinx-wavedrom
Awaiting triage
Development

No branches or pull requests

2 participants