-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to f-strings #209
Comments
This was referenced May 9, 2020
Merged
Merged
OK, as we've agreed to drop Python 3.5 after 0.8.0 release, I'd like to list all files in the project that should be checked for replacing
|
This was referenced Jun 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
m2cgen's codebase heavily utilizes string formatting and concatenation mechanisms.
f-strings
(brief guide) are known to be the fastest method to format string (1, 2) and they increase code readability a lot.Source: https://cito.github.io/blog/f-strings/.
One problem is only that they are supported starting from Python 3.6, but currently m2cgen supports Python 3.5.
m2cgen/setup.py
Line 28 in 7626a60
My suggestion is the following. Mark the next
0.8.0
release as the latest which supports Python 3.5 and drop the support in0.9.0
release. It will be approximately in the same time as Python 3.5 reaches its EOL (2020-09-13).The text was updated successfully, but these errors were encountered: