Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error converting to String #21

Closed
bendangelo opened this issue Jun 13, 2024 · 4 comments
Closed

Error converting to String #21

bendangelo opened this issue Jun 13, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@bendangelo
Copy link

Just pulled the repo and getting this error. Using Ruby 3.3.3

Steps:

bin/setup
rake build
rake spec
=>
TypeError:                                                                                                                                                
        Error converting to String                                                                                                                              
      # ./lib/tantiny/tokenizer.rb:15:in `__new_stemmer_tokenizer'                                                                                              
      # ./lib/tantiny/tokenizer.rb:15:in `new'                         
@baygeldin baygeldin added the bug Something isn't working label Jun 14, 2024
@baygeldin
Copy link
Owner

The code really does become obsolete very quickly if not supported, huh... I'll try to fix it next week, but I'll be honest, after that I'll probably archive the repo 😢 The project that I'm working on currently doesn't have a use for this gem, and I don't have the spare time to support it.

@bendangelo
Copy link
Author

No problem. A fix would be much appriciated.

@baygeldin
Copy link
Owner

Okay, so it turned out to be way more complicated than I hoped for, unfortunately. The issue is with the rutie gem that provides Ruby/Rust bindings. Apparently it doesn't support Ruby 3.x.x, although I haven't found it be the case when running specs on my local machine with Ruby 3.3.3 and Rust 1.76.0. However, when I updated Rust to 1.79.0 and everything broke :/ Again, seems to be a problem with rutie.

One option is to rewrite the gem to using magnus (example), but this will take some effort and I'm not confident that it wouldn't have the same issues with support down the line.

@bendangelo
Copy link
Author

I'm on Rust 1.79.0. So maybe just update the docs to say only supports Rust 1.76.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants