Skip to content
This repository has been archived by the owner on Dec 6, 2019. It is now read-only.

Fork & Pull Request #32

Open
vfabregat opened this issue Nov 27, 2017 · 2 comments
Open

Fork & Pull Request #32

vfabregat opened this issue Nov 27, 2017 · 2 comments

Comments

@vfabregat
Copy link

Hi!
We did a few mofications in your library, and we want to know if you are interested in a PR to publish this changes in NPM.

Here you can check the changes: https://github.com/valudio/electron-notifications

The summary changes are:

  • Changed the layout to use flex.
  • Changed the styles
  • Added the following options:
    • devTools: to show the devTools
    • backgroundColor: Added the option to change the default background color
    • buttonsColor: Option to change the default buttons color
    • textFontSize: Added the option to change the text font size
  • Allow to set notification without a duration
  • The title is not required anymore

If you want, we'll be delighted to sent you a PR with those changes

Regards

@bayleedev
Copy link
Owner

Yes, I'd love that!

@vfabregat
Copy link
Author

Nice! I created the PR, let me know if you have any problem.

regards

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants