Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing kiss_fftnd from libkissfft.so #8

Open
utkarshayachit opened this issue Feb 14, 2018 · 3 comments
Open

missing kiss_fftnd from libkissfft.so #8

utkarshayachit opened this issue Feb 14, 2018 · 3 comments

Comments

@utkarshayachit
Copy link

The primary library libkissfft.so doesn not include .*_fftnd APIs. Why is that? Are they not part of the public API? Is they are, would it make sense to built it in the toplevel Makefile itself?

cc: @mathstuf

@itdaniher
Copy link
Collaborator

kiss_fftnd.c isn't compiled into the .so by the main level Makefile, and the makefile in tools just builds the fft_float executable, which doesn't expose a low-level API offering fftnd - it likely wouldn't be hard to fix this, but I don't have the bandwidth right now.

@itdaniher
Copy link
Collaborator

to directly answer your question - there's no reason I have not to expose _fftnd as a first-class API - the original author didn't, but it seems like a useful abstraction to include in the scope of the top level API.

@utkarshayachit
Copy link
Author

thanks! I'll have a pull request when I get around to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants