Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide an option to override bazel command #80

Open
alokpr opened this issue Dec 29, 2023 · 2 comments
Open

Provide an option to override bazel command #80

alokpr opened this issue Dec 29, 2023 · 2 comments

Comments

@alokpr
Copy link
Contributor

alokpr commented Dec 29, 2023

The driver runs 'build' or 'test' depending on the target type. The 'test' command however does not make sense for some build configs like clang-tidy which only performs static analysis.

The driver should provide a 'command' option which can be set to either 'build' or 'auto' (current behavior)

@alokpr
Copy link
Contributor Author

alokpr commented Dec 29, 2023

Happy to send PR if the feature request sounds reasonable

@illicitonion
Copy link
Collaborator

I think this sounds reasonable and would gladly review a PR for it :)

This is about the limit of the kind of complexity/configurability I think is reasonable to add to driver though - in general driver is intended as more of an example which may work for simple use-cases. If you're looking to add much more functionality to it, I'd consider writing your own tool which uses the WalkAffectedTargets API (which is intended as a building block for a more complex CI driver), as in my experience everyone wants slightly different CI set-ups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants