Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language/go: embedsrcs not correctly populated when using all: prefixed patterns #1431

Closed
mbicz opened this issue Jan 27, 2023 · 0 comments · Fixed by #1432
Closed

language/go: embedsrcs not correctly populated when using all: prefixed patterns #1431

mbicz opened this issue Jan 27, 2023 · 0 comments · Fixed by #1432

Comments

@mbicz
Copy link
Contributor

mbicz commented Jan 27, 2023

What version of gazelle are you using?

2224160

What version of rules_go are you using?

v0.38.0

What version of Bazel are you using?

6.0.0-homebrew

Does this issue reproduce with the latest releases of all the above?

yes

What operating system and processor architecture are you using?

 Darwin Kernel Version 22.2.0: Fri Nov 11 02:08:47 PST 2022; root:xnu-8792.61.2~4/RELEASE_X86_64 x86_64

What did you do?

assuming

% tree data
data
└── __hidden.txt

0 directories, 1 file

main.go

package "main"

//go:embed data all:*
var Data embed.FS
...

What did you expect to see?

go_library(
    name = "go_default_library",
    srcs = ["main.go"],
    embedsrcs = ["data/__hidden__.txt"],
    importpath = "...",
    visibility = ["//visibility:private"],
)

What did you see instead?

...
... could not embed all:*: no matching files found
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant