Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add types.is_depset? #104

Closed
allevato opened this issue Feb 1, 2019 · 1 comment
Closed

Should we add types.is_depset? #104

allevato opened this issue Feb 1, 2019 · 1 comment

Comments

@allevato
Copy link
Member

allevato commented Feb 1, 2019

We're migrating rules_swift to use the types module instead of type(foo) == type(bar), but we can't update all of them since there's not a types.is_depset. I have to check the type because I'm writing action wrappers that need to augment the tools/inputs passed into them, which means knowing whether it's a depset or a list and performing the right operation.

Any reason we shouldn't do this?

@laurentlb
Copy link
Contributor

I think we can add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants