Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using new string_flag settings in external repositories #10152

Closed
keith opened this issue Nov 1, 2019 · 2 comments
Closed

Using new string_flag settings in external repositories #10152

keith opened this issue Nov 1, 2019 · 2 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request

Comments

@keith
Copy link
Member

keith commented Nov 1, 2019

With the new string_flag type, it would be nice if we could include some of these in rules repos, but currently it doesn't seem like you can reference them if they're in a WORKSPACE repo in your project. For example if we add this:

string_flag(
    name = "ios_simulator_id",
    build_setting_default = "",
    visibility = ["//visibility:public"],
)

To rules_apple, and then try to set it with:

bazel test //... --@build_bazel_rules_apple//apple:ios_simulator_id=foo

We get this error:

ERROR: Unrecognized option: --@build_bazel_rules_apple//apple:ios_simulator_id=foo

I also tried using //external here with no luck.

What's the output of bazel info release?

release 1.1.0

Related: bazelbuild/rules_apple#648

@dslomov dslomov added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. untriaged labels Nov 25, 2019
@laurentlb laurentlb added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request and removed untriaged labels Jan 9, 2020
@gregestren
Copy link
Contributor

Let's consolidate these bugs into #11128.

When that one is fixed, it if doesn't address this we can re-open this.

@juliexxia
Copy link
Contributor

I believe this is fixed by #10039

Random repo I used was

$ git clone git clone https://github.com/bazelbuild/rules_go
$ bazel build :default_nogo --@io_bazel_rules_go//go/config:incompatible_package_conflict_is_error=True

@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
None yet
Development

No branches or pull requests

6 participants