Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazel CI: Flip --incompatible_remap_main_repo broke many projects in downstream #10246

Closed
meteorcloudy opened this issue Nov 15, 2019 · 5 comments
Assignees
Labels
breakage P1 I'll work on this now. (Assignee required)

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 15, 2019

@meteorcloudy meteorcloudy added P1 I'll work on this now. (Assignee required) breakage labels Nov 15, 2019
@meteorcloudy
Copy link
Member Author

Ping @aehlig , Should we revert the flip or disable all broken downstream projects?
/cc @dslomov

@aehlig
Copy link
Contributor

aehlig commented Nov 18, 2019

Ping @aehlig , Should we revert the flip or disable all broken downstream projects?

For rules_go I'm pretty sure the breakage is due to the implicit assumption in that repository that every artifact path generated by bazel starts with external/. So there, it is the downstream project at fault.

For rules_rust I still haven't managed to find out what the root cause of this breakage is. So I still cannot tell, if flag flip uncovered a bug in rules_rust or in bazel (but, on the other hand, #3115 and #7180 are bugs in bazel as well).

@laurentlb
Copy link
Contributor

If project maintainers should fix the code or take a look at the issue, please file bugs.

@aehlig
Copy link
Contributor

aehlig commented Nov 19, 2019

Filed issue for rules_go. Again, for rules_rust it is not clear in which code (bazel or rules_rust) the underlying issue is.

@aehlig
Copy link
Contributor

aehlig commented Dec 16, 2019

Corresponding issues and/or pull requests have been filed.

@aehlig aehlig closed this as completed Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakage P1 I'll work on this now. (Assignee required)
Projects
None yet
Development

No branches or pull requests

3 participants