Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify open source contributors when patches are reverted #12691

Open
keith opened this issue Dec 11, 2020 · 3 comments
Open

Notify open source contributors when patches are reverted #12691

keith opened this issue Dec 11, 2020 · 3 comments
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling not stale Issues or PRs that are inactive but not considered stale P3 We're not considering working on this, but happy to review a PR. (No assignee) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process

Comments

@keith
Copy link
Member

keith commented Dec 11, 2020

Sometimes patches pass public CI and are merged, and are then reverted because of internal issues at Google. In this case there's no notification for the original author that the patch was reverted, which means it could be lost indefinitely and not attempted to be re-merged.

Can public contributors be notified when their patches are reverted?

@aiuto aiuto added area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling untriaged team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Jan 7, 2021
@philwo philwo added P3 We're not considering working on this, but happy to review a PR. (No assignee) type: process and removed untriaged labels Feb 8, 2021
@alexeagle
Copy link
Contributor

Note, discussing this in the rules authors SIG, has caused important commits to nearly miss a release.

We just need the Piper revert to include the github handle of the original author in the changelist description so it produces a ping when that commit gets exported to github?

@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jun 8, 2023
@brentleyjones
Copy link
Contributor

Not stale

@brentleyjones brentleyjones added not stale Issues or PRs that are inactive but not considered stale and removed stale Issues or PRs that are stale (no activity for 30 days) labels Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-EngProd Bazel CI, infrastructure, bootstrapping, release, and distribution tooling not stale Issues or PRs that are inactive but not considered stale P3 We're not considering working on this, but happy to review a PR. (No assignee) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process
Projects
None yet
Development

No branches or pull requests

5 participants