Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing mandatory field didn't error on bazel 0.2.3 #1295

Closed
johnynek opened this issue May 19, 2016 · 1 comment
Closed

missing mandatory field didn't error on bazel 0.2.3 #1295

johnynek opened this issue May 19, 2016 · 1 comment
Assignees
Labels
P1 I'll work on this now. (Assignee required) type: bug
Milestone

Comments

@johnynek
Copy link
Member

in the scala rules we have:

https://github.com/bazelbuild/rules_scala/blob/master/scala/scala.bzl#L410

"main_class": attr.string(mandatory=True),

despite that, on bazel 0.2.3, we don't get an error with a missing main_class attribute (which leads to confusing error messages when the manifest is incorrect and we try to run.

@kchodorow kchodorow added type: bug P1 I'll work on this now. (Assignee required) category: skylark P2 We'll consider working on this in future. (Assignee optional) and removed P1 I'll work on this now. (Assignee required) labels May 20, 2016
@dslomov dslomov added this to the 0.5 milestone Dec 8, 2016
@dslomov dslomov added P1 I'll work on this now. (Assignee required) and removed P2 We'll consider working on this in future. (Assignee optional) labels Dec 20, 2016
@dslomov dslomov assigned vladmos and brandjon and unassigned vladmos Dec 20, 2016
@brandjon
Copy link
Member

I'm unable to reproduce using a toy example under either a recent version (0.4.0) or 0.2.3.

Looking at the line you linked, if you're talking about the scala_library rule, it doesn't have the mandatory flag on "main_class" (line 531), only scala_binary does. (I don't know Scala but I assume it's expected that a library wouldn't need a main class.) If you're having an issue with another rule where the mandatory flag isn't being respected, please reopen and provide an example failure. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Development

No branches or pull requests

6 participants