Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support several downloader configs #13131

Open
pilkjaer opened this issue Mar 1, 2021 · 6 comments
Open

Support several downloader configs #13131

pilkjaer opened this issue Mar 1, 2021 · 6 comments
Labels
help wanted Someone outside the Bazel team could own this not stale Issues or PRs that are inactive but not considered stale P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request

Comments

@pilkjaer
Copy link

pilkjaer commented Mar 1, 2021

Description of the problem / feature request:

Currently --experimental_downloader_config flag only supports one value. It's not possible to provide several files. Providing several files doesn't result in any error but only one file is being used.

Feature requests: what underlying problem are you trying to solve with this feature?

We use Bazel in several projects and we would like to be able to provide one downloader_config centrally and then for each project to be able to provide their own additional downloader_config file when needed.

What operating system are you running Bazel on?

RHEL7

What's the output of bazel info release?

release 4.0.0

What's the output of git remote get-url origin ; git rev-parse master ; git rev-parse HEAD ?

https://github.com/bazelbuild/bazel.git
a3c52a7
6b33bdb

Have you found anything relevant by searching the web?

No. Current possible solution is having some kind of script to combine downloader config files prior bazel build which is not optimal.

Any other information, logs, or outputs that you want to share?

We can try to make an implementation and submit it as pull request if idea of having several downloader configs is OK with you.

@pilkjaer
Copy link
Author

pilkjaer commented Mar 1, 2021

Feature request is related to 9d29464 that introduces feature.

@jin jin added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: feature request untriaged labels Mar 2, 2021
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
@Wyverald Wyverald added help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Feb 7, 2022
@Wyverald
Copy link
Member

Wyverald commented Feb 7, 2022

Seems like a reasonable change (making it possible to specify the flag multiple times). Happy to accept PRs.

cc @shs96c

@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jun 13, 2023
@github-actions
Copy link

This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team (@bazelbuild/triage). Thanks!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
@pilkjaer
Copy link
Author

@bazelbuild/triage We are still interested in this feature and would like to see it implemented.

@brentleyjones brentleyjones added not stale Issues or PRs that are inactive but not considered stale and removed stale Issues or PRs that are stale (no activity for 30 days) labels Aug 21, 2023
@brentleyjones brentleyjones reopened this Aug 21, 2023
@faximan
Copy link

faximan commented Apr 15, 2024

+1 to this FR.

Another option could be to allow one config to include another.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone outside the Bazel team could own this not stale Issues or PRs that are inactive but not considered stale P3 We're not considering working on this, but happy to review a PR. (No assignee) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
None yet
Development

No branches or pull requests

6 participants