Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation issue: Common C Build Use Cases #13508

Open
samlaf opened this issue May 22, 2021 · 0 comments
Open

Documentation issue: Common C Build Use Cases #13508

samlaf opened this issue May 22, 2021 · 0 comments
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: documentation (cleanup)

Comments

@samlaf
Copy link

samlaf commented May 22, 2021

Documentation URL: https://docs.bazel.build/versions/4.1.0/cpp-use-cases.html

The sections Including external libraries and Writing and running C++ tests are untestable in the current state.

  1. The ./test/hello-test.cc file includes #include "lib/hello-greet.h", but nowhere was hello-greet mentioned. I guessed it was referring to the structure in stage3 of the previous tutorial, but hello-greet.h in that tutorial is in main/ and not /lib.

I ended up creating a directory structure like

image

which managed to work, but it would be nice to add this to the github cpp-tutorial, maybe as a 4th stage.

  1. The other problem is that the first WORKSPACE + gtest.BUILD (without the strip_prefix) in https://docs.bazel.build/versions/4.1.0/cpp-use-cases.html#including-external-libraries didn't compile for me. I get the error:

image

@jin jin added team-Rules-CPP Issues for C++ rules untriaged labels May 24, 2021
@oquenchil oquenchil added type: documentation (cleanup) P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels May 25, 2021
@ShreeM01 ShreeM01 added the team-Documentation Documentation improvements that cannot be directly linked to other team labels label Jan 10, 2023
@keertk keertk added the help wanted Someone outside the Bazel team could own this label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

5 participants