Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of Bazel 5.0.0-pre.20210510.2 #13526

Closed
5 tasks done
fweikert opened this issue May 27, 2021 · 10 comments
Closed
5 tasks done

Status of Bazel 5.0.0-pre.20210510.2 #13526

fweikert opened this issue May 27, 2021 · 10 comments
Assignees
Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process

Comments

@fweikert
Copy link
Member

fweikert commented May 27, 2021

  • Expected release date: Last week of May / First week of June

Task list:

@fweikert fweikert added release P1 I'll work on this now. (Assignee required) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process labels May 27, 2021
@fweikert fweikert self-assigned this May 27, 2021
@fweikert
Copy link
Member Author

@davido
Copy link
Contributor

davido commented Jun 1, 2021

@fweikert

red build is good. Much worse is the situation with green build that produces broken result.

As explained in #7849 (comment) Bazel issues this warning:

WARNING: Option 'java_toolchain' is deprecated

and ignores java_toolchain, for example for projects that want to produce Java 11 major byte code.

Unfortunately, the attempt to un-flip --incompatible_use_toolchain_resolution_for_java_rules=false doesn't work.

The only way forward is to migrate to incompatible_use_toolchain_resolution_for_java_rules. Something like: [1] is needed for all projects that use custom java_toolchain.

Can this be clarified in the release notes, or alternatively avoid releasing Bazel in this state?

[1] https://gerrit-review.googlesource.com/c/gerrit/+/291864

@haberman
Copy link
Contributor

haberman commented Jun 1, 2021

My builds have just started failing (since yesterday). I am using use_bazel.sh latest.

+ use_bazel.sh latest
+ filename=bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh
+ cmd='curl  -sLO --retry 5 --retry-max-time 10   https://storage.googleapis.com/bazel/5.0.0-pre.20210510.2.2/release/bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh'
+ eval 'curl  -sLO --retry 5 --retry-max-time 10   https://storage.googleapis.com/bazel/5.0.0-pre.20210510.2.2/release/bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh'
++ curl -sLO --retry 5 --retry-max-time 10 https://storage.googleapis.com/bazel/5.0.0-pre.20210510.2.2/release/bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh
+ sudo mkdir -p /usr/local/bazel/5.0.0-pre.20210510.2.2
+ chmod 755 bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh
+ command='sudo "./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh" "--prefix=/usr/local/bazel/5.0.0-pre.20210510.2.2" '
+ eval 'sudo "./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh" "--prefix=/usr/local/bazel/5.0.0-pre.20210510.2.2" '
++ sudo ./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh --prefix=/usr/local/bazel/5.0.0-pre.20210510.2.2
./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh: 1: ./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh: Syntax error: redirection unexpected

https://source.cloud.google.com/results/invocations/1d3fd36e-7834-46c8-a4fb-17faff0bc25b/targets/upb%2Fubuntu%2Fpresubmit/log

It looks like the Linux installer for 5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh is broken somehow?

@haberman
Copy link
Contributor

haberman commented Jun 2, 2021

Any comment on the error above? This is breaking all of my Kokoro builds on https://github.com/protocolbuffers/upb at the moment.

@matthewstevenson88
Copy link

+1, also breaking my Kokoro builds.

@hlopko
Copy link
Member

hlopko commented Jun 9, 2021

Could we re-check downstream projects? Rules Rust have been reenabled recently (and there's a lot of red stuff in the link, is that expected and ok?)

@matthewstevenson88
Copy link

I'm still seeing failures as this morning. The relevant logs are here:

+ use_bazel.sh latest
+ filename=bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh
+ cmd='curl  -sLO --retry 5 --retry-max-time 10   https://storage.googleapis.com/bazel/5.0.0-pre.20210510.2.2/release/bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh'
+ eval 'curl  -sLO --retry 5 --retry-max-time 10   https://storage.googleapis.com/bazel/5.0.0-pre.20210510.2.2/release/bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh'
++ curl -sLO --retry 5 --retry-max-time 10 https://storage.googleapis.com/bazel/5.0.0-pre.20210510.2.2/release/bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh
+ sudo mkdir -p /usr/local/bazel/5.0.0-pre.20210510.2.2
+ chmod 755 bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh
+ command='sudo "./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh" "--prefix=/usr/local/bazel/5.0.0-pre.20210510.2.2" '
+ eval 'sudo "./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh" "--prefix=/usr/local/bazel/5.0.0-pre.20210510.2.2" '
++ sudo ./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh --prefix=/usr/local/bazel/5.0.0-pre.20210510.2.2
./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh: 1: ./bazel-5.0.0-pre.20210510.2.2-installer-linux-x86_64.sh: Syntax error: redirection unexpected

This looks similar to the logs in @haberman's PR here: protocolbuffers/upb#400

@fweikert
Copy link
Member Author

Back from OOO. Several thoughts:

  1. This very first rolling release was mostly a test for our release infrastructure. I didn't expect any real usage yet, but in hindsight I should have communicated that clearly.
  2. We (Bazel team) still need to determine and document our SLO for such releases. For example, which tests have to be passed in order to proceed with a release.
  3. Since rolling releases are tied to Blaze releases we'll likely have weekly releases in the future, which means that we probably won't cherrypick commits (still being debated).
  4. Re Kokoro: Can you use the latest LTS release instead? https://api.github.com/repos/bazelbuild/bazel/releases/latest ignores rolling releases since they're marked as "prerelease".

@fweikert
Copy link
Member Author

fweikert commented Jun 10, 2021

The most recent rolling release is https://github.com/bazelbuild/bazel/releases/tag/5.0.0-pre.20210520.7, and there will be another one tomorrow if today's Blaze release doesn't get rolled back.

@matthewstevenson88
Copy link

Thanks @fweikert, downgraded our Bazel version for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) release team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: process
Projects
None yet
Development

No branches or pull requests

5 participants