Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toolchains attribute on all rules should merge runfiles from the toolchain into the depending target #14014

Open
illicitonion opened this issue Sep 20, 2021 · 5 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Configurability Issues for Configurability team type: feature request

Comments

@illicitonion
Copy link
Contributor

See bazelbuild/rules_nodejs#2960 (comment)

@illicitonion
Copy link
Contributor Author

/cc @katre @alexeagle

@katre
Copy link
Member

katre commented Sep 20, 2021

This prevents the need to duplicate a target in both toolchains and tools.

@katre katre added P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Configurability Issues for Configurability team type: feature request labels Sep 20, 2021
@github-actions
Copy link

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team (@bazelbuild/triage) if you think this issue is still relevant or you are interested in getting the issue resolved.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label May 25, 2023
@alexeagle
Copy link
Contributor

I think this is still valid.

@sgowroji sgowroji removed the stale Issues or PRs that are stale (no activity for 30 days) label May 25, 2023
@katre
Copy link
Member

katre commented May 25, 2023

We should rename the existing toolchains attribute, since what it does isn't really part of toolchains.

Unfortunately, that's a major task and no one has time to pick it up.

We should keep this alive, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Configurability Issues for Configurability team type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants