Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation reference shard_count heuristics #14446

Open
pauldraper opened this issue Dec 19, 2021 · 0 comments
Open

Documentation reference shard_count heuristics #14446

pauldraper opened this issue Dec 19, 2021 · 0 comments
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels type: documentation (cleanup)

Comments

@pauldraper
Copy link
Contributor

pauldraper commented Dec 19, 2021

The documentation for shard_count says:

This value will override any heuristics used to determine the number of parallel shards with which to run the test. Note that for some test rules, this parameter may be required to enable sharding in the first place. Also see --test_sharding_strategy.

But the docs also say the only permitted values for --test_sharding_strategy are explicit and disabled. In other words, Bazel never shards a test that doesn't specify shard_count.

The reference to heuristics appears to be vestigial (or future?).

@gregestren gregestren added team-Rules-Server Issues for serverside rules included with Bazel type: documentation (cleanup) untriaged labels Jan 31, 2022
@comius comius added team-Documentation Documentation improvements that cannot be directly linked to other team labels and removed team-Rules-Server Issues for serverside rules included with Bazel labels Jul 19, 2022
@keertk keertk added help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

4 participants