Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release-5.2.0rc1 Builds are failing. #15545

Closed
ckolli5 opened this issue May 20, 2022 · 6 comments
Closed

Release-5.2.0rc1 Builds are failing. #15545

ckolli5 opened this issue May 20, 2022 · 6 comments

Comments

@ckolli5
Copy link

ckolli5 commented May 20, 2022

Description of the bug:

Release-5.2.0rc1 builds are failing with the following errors:


OpenJDK 11, gcc 7.4.0 - //src/test/shell/bazel/android:aidl_integration_test_with_head_android_tools FAILED TO BUILD

20.04 LTS OpenJDK 11, gcc 9.3.0 - //src/test/shell/bazel/android:android_integration_test_with_head_android_tools FAILED TO BUILD

OpenJDK 11, Xcode - /src/test/java/com/google/devtools/build/android/r8:AllTests   FAILED TO BUILD

OpenJDK 11, VS2017 - //src/test/shell/bazel/android:aidl_integration_test_with_head_android_tools FAILED TO BUILD

18.04 LTS OpenJDK 11, gcc 7.4.0 - //src/test/java/com/google/devtools/build/android/r8:AllTests   FAILED TO BUILD```

These are not failing in the latest Bazel.


### What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.


_No response_

### Which operating system are you running Bazel on?


_No response_

### What is the output of `bazel info release`?


_No response_

### If `bazel info release` returns `development version` or `(@non-git)`, tell us how you built Bazel.


_No response_

### What's the output of `git remote get-url origin; git rev-parse master; git rev-parse HEAD` ?


_No response_

### Have you found anything relevant by searching the web?

_No response_

### Any other information, logs, or outputs that you want to share?

Here is the buildkite log: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2475
@meteorcloudy
Copy link
Member

Link to the failed downstream build: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/2475

external/desugar_jdk_libs/src/share/classes/java/util/stream/Collectors.java:631: error: [ReturnValueIgnored] Return value of 'sumWithCompensation' must be used
                (a, b) -> { sumWithCompensation(a, b[0]); sumWithCompensation(a, b[1]); a[2] += b[2]; a[3] += b[3]; return a; },
                                                                             ^
    (see https://errorprone.info/bugpattern/ReturnValueIgnored)
  Did you mean '(a, b) -> { sumWithCompensation(a, b[0]);  a[2] += b[2]; a[3] += b[3]; return a; },'?

@meteorcloudy
Copy link
Member

@cushon Bazel@HEAD is green when building Bazel itself at the latest commit, but not Bazel 5.2.0 rc1, do you know which change we're missing in the release branch?

@meteorcloudy
Copy link
Member

Probably we need to cherry-pick this one: cf57345

@hvadehra Can you please confirm this?

@cushon
Copy link
Contributor

cushon commented May 23, 2022

@comius @hvadehra

This is #15219, cherry-picking 9fad5a3 SG

There was some discussion in the other bug about suppressing this locally for the desugar target, which I still think would be a worthwhile follow-up

@meteorcloudy
Copy link
Member

There was some discussion in the other bug about suppressing this locally for the desugar target, which I still think would be a worthwhile follow-up

I guess that change is not necessary for the 5.2 release?

@meteorcloudy
Copy link
Member

9fad5a3 has been cherry-picked in #15559 to fix the issue in 5.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants