Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ancient PY2 warning messages from python_stub_template.txt #15783

Closed
wants to merge 3 commits into from
Closed

Remove ancient PY2 warning messages from python_stub_template.txt #15783

wants to merge 3 commits into from

Conversation

jvolkman
Copy link
Contributor

@jvolkman jvolkman commented Jul 1, 2022

These messages are rarely helpful and often misleading. The associated TODO (#6443) was closed years ago.

@jvolkman
Remove ancient PY2 warning messages from python_stub_template.txt
cf7fafe 
These messages are rarely helpful and often misleading. The associated TODO (bazelbuild#6443) was closed years ago.
@sgowroji sgowroji added team-Rules-Python Native rules for Python awaiting-user-response Awaiting a response from the author labels Jul 1, 2022
@jvolkman
Copy link
Contributor Author

jvolkman commented Jul 1, 2022

Turns out there was a test case. I've removed that as well and the tests are passing now.

@groodt
Copy link
Contributor

groodt commented Jul 1, 2022

Should this be removed as well?

bazel/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java

Line 181 in c3d43ec

"%enable_host_version_warning%",

@jvolkman jvolkman requested a review from lberki as a code owner July 1, 2022 20:41
@jvolkman
Copy link
Contributor Author

jvolkman commented Jul 1, 2022

Should this be removed as well?

bazel/src/main/java/com/google/devtools/build/lib/bazel/rules/python/BazelPythonSemantics.java

Line 181 in c3d43ec

"%enable_host_version_warning%",

Good catch.

groodt
groodt approved these changes Jul 3, 2022
View reviewed changes
Copy link
Contributor

@groodt groodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgowroji sgowroji added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-user-response Awaiting a response from the author labels Jul 4, 2022
@comius comius requested review from comius and removed request for lberki July 21, 2022 09:27
@comius
Copy link
Contributor

comius commented Jul 21, 2022

cc @rickeylev can you take a look at this?

@jvolkman jvolkman deleted the patch-1 branch July 21, 2022 13:46
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@groodt groodt groodt approved these changes

@comius comius comius approved these changes

Assignees
No one assigned
Labels
team-Rules-Python Native rules for Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jvolkman @groodt @comius @sgowroji @ShreeM01