Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdeps behavior differs between standard and skyquery when --notool_deps is set #15977

Open
keith opened this issue Jul 25, 2022 · 5 comments
Open
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Core Skyframe, bazel query, BEP, options parsing, bazelrc type: bug untriaged

Comments

@keith
Copy link
Member

keith commented Jul 25, 2022

Description of the bug:

When querying for the rdeps of a file that is part of a tool with --notool_deps, the tool is returned even though it is outside of the rdeps scope (but not outside of the universe scope), only with skyquery.

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Using this project: rdepsrepro.zip

$ USE_BAZEL_VERSION=rolling bazelisk query 'rdeps(//src/..., set(tools/main.c))'
INFO: Empty results
$ USE_BAZEL_VERSION=rolling bazelisk query --config=repro 'rdeps(//src/..., set(tools/main.c))'
//tools:main.c
//tools:tool

(flags are set in the .bazelrc)

Which operating system are you running Bazel on?

macOS

What is the output of bazel info release?

release 6.0.0-pre.20220706.4 (also repros with the latest release)

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@sgowroji sgowroji added type: bug untriaged team-Core Skyframe, bazel query, BEP, options parsing, bazelrc labels Jul 26, 2022
@haxorz
Copy link
Contributor

haxorz commented Jul 26, 2022

Interesting. Just from your report, I don't have a guess what's going wrong.

--config=repro ... (flags are set in the .bazelrc)

I didn't see a .bazelrc file in your zip. What flags does --config=repro expand to?

@jpsim
Copy link

jpsim commented Jul 26, 2022

It's in the zip, but it's a hidden file since it starts with a .. Here's the contents of .bazelrc from the zip:

query --notool_deps
query --order_output=no

query:repro --universe_scope=//...

@haxorz
Copy link
Contributor

haxorz commented Jul 26, 2022

ty! Didn't realize the ChromeOS file browser UI hides hidden files by default :p

@haxorz
Copy link
Contributor

haxorz commented Sep 20, 2022

@shreyax Can you please triage?

@shreyax
Copy link
Contributor

shreyax commented Oct 25, 2022

I will keep this issue assigned to me

@haxorz haxorz added the P2 We'll consider working on this in future. (Assignee optional) label Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Core Skyframe, bazel query, BEP, options parsing, bazelrc type: bug untriaged
Projects
None yet
Development

No branches or pull requests

5 participants