Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible for source files to be unresolved symlinks #16712

Open
lberki opened this issue Nov 9, 2022 · 5 comments
Open

Make it possible for source files to be unresolved symlinks #16712

lberki opened this issue Nov 9, 2022 · 5 comments
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Core Skyframe, bazel query, BEP, options parsing, bazelrc type: feature request

Comments

@lberki
Copy link
Contributor

lberki commented Nov 9, 2022

Description of the feature request:

Generated files can now be unresolved symlinks, in which case Bazel uses the value returned by readlink() and not by read() to determine whether it has changed; they can even be dangling symlinks that way.

For symmetry, it would be nice if source files also had this ability.

What underlying problem are you trying to solve with this feature?

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@lberki lberki added the team-Core Skyframe, bazel query, BEP, options parsing, bazelrc label Nov 9, 2022
@haxorz
Copy link
Contributor

haxorz commented Nov 14, 2022

Generated files can now be unresolved symlinks

This is referring to the --experimental_allow_unresolved_symlinks flag discussed in #10298 and especially the recent flip of the default value of that flag in 27cfc83, right?

@lberki
Copy link
Contributor Author

lberki commented Nov 16, 2022

Yep.

@larsrc-google
Copy link
Contributor

Do you have an actual use case for this? Symmetry sounds nice, but not adding code that doesn't get used sounds even nicer.

@lberki
Copy link
Contributor Author

lberki commented Nov 17, 2022

My understanding is that the Chrome OS SDK contains file system trees and those have symlinks that are not dangling when installed, but are dangling on the system where the build happens.

I'll add to you to the pertinent thread.

@haxorz haxorz added the P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) label Dec 2, 2022
Copy link

github-actions bot commented Feb 6, 2024

Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this issue is still relevant and should stay open, please post any comment here and the issue will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Feb 6, 2024
@fmeum fmeum removed the stale Issues or PRs that are stale (no activity for 30 days) label Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Core Skyframe, bazel query, BEP, options parsing, bazelrc type: feature request
Projects
None yet
Development

No branches or pull requests

5 participants