Do not count tests as failed that have not started #17160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, when the user interrupted a test run, tests that had not started until that point were counted as failed, whereas tests that were already running were counted as skipped. With this commmit, both types of tests are counted as skipped.
|
@meisterT Could you review this PR? |
ShreeM01
added
team-Performance
meisterT
added
team-Core
|
@haxorz introduced this (a long time ago) - looks benign to me, but you might want to have a look. |
haxorz
approved these changes
Jan 9, 2023
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
haxorz
added
awaiting-PR-merge
|
The label is to indicate that we would like the cherry-pick it into 6.1. If it's not an incompatible change it would be nice to get the label back. |
haxorz
added
the
potential release blocker
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 24, 2023
Before this commit, when the user interrupted a test run, tests that had not started until that point were counted as failed, whereas tests that were already running were counted as skipped. With this commmit, both types of tests are counted as skipped. Closes #17160. PiperOrigin-RevId: 501495265 Change-Id: I4dd157c32d70eb46a02070251684899b84c9802e Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
hvadehra
pushed a commit
that referenced
this pull request
Feb 14, 2023
Before this commit, when the user interrupted a test run, tests that had not started until that point were counted as failed, whereas tests that were already running were counted as skipped. With this commmit, both types of tests are counted as skipped. Closes #17160. PiperOrigin-RevId: 501495265 Change-Id: I4dd157c32d70eb46a02070251684899b84c9802e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, when the user interrupted a test run, tests that had not started until that point were counted as failed, whereas tests that were already running were counted as skipped.
With this commmit, both types of tests are counted as skipped.