Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel.build] Problem with /start/cpp #18341

Open
chjfth opened this issue May 8, 2023 · 4 comments
Open

[bazel.build] Problem with /start/cpp #18341

chjfth opened this issue May 8, 2023 · 4 comments
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: documentation (cleanup)

Comments

@chjfth
Copy link
Contributor

chjfth commented May 8, 2023

Page link:

https://bazel.build/start/cpp

Problem description (include actual vs expected text, if applicable):

In Stage 2 ,there is sentence saying "you can see that hello-world depends on the same inputs as it did before".

That is wrong! Stage 2's hello-world clearly depends on different input compared to Stage 1.

Where do you see this issue? (include link to specific section of the page, if applicable)

same inputs as it did before, but the structure of the build is different:

Any other information you'd like to share?

No response

@chjfth chjfth added team-Documentation Documentation improvements that cannot be directly linked to other team labels type: documentation (cleanup) untriaged labels May 8, 2023
@keertk keertk added P3 We're not considering working on this, but happy to review a PR. (No assignee) help wanted Someone outside the Bazel team could own this and removed untriaged labels May 8, 2023
@keertk
Copy link
Member

keertk commented May 8, 2023

Hi @chjfth would you be willing to submit a PR to fix this?

@chjfth
Copy link
Contributor Author

chjfth commented May 13, 2023

I've created a PR for this #18390

@chjfth
Copy link
Contributor Author

chjfth commented May 13, 2023

The PR process seems to stop at google-cla bot.

I have added myself to https://cla.developers.google.com/ ,

The resulting page shows: https://i.stack.imgur.com/ps1NE.png

But two hours have passed, the cla/google checking still shows red cross. Why is that?

@keertk
Copy link
Member

keertk commented May 13, 2023

I just reran the CLA check and it looks good now. Thanks for submitting the PR! We'll review and merge.

@iancha1992 iancha1992 added the team-Rules-CPP Issues for C++ rules label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

5 participants