Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunset C++ toolchain legacy features #22005

Open
daivinhtran opened this issue Apr 15, 2024 · 0 comments
Open

Sunset C++ toolchain legacy features #22005

daivinhtran opened this issue Apr 15, 2024 · 0 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: feature request

Comments

@daivinhtran
Copy link
Contributor

From https://bazel.build/versions/6.2.0/docs/cc-toolchain-config-reference#legacy-features-patching-logic:

This is a long list of features. The plan is to get rid of them once Crosstool in Starlark is done.

Most of the legacy features are migrated to Starlark. We should consider sunsetting these legacy features when possible.

The pain point with legacy features is that it's sometime a mystery which features are enabled.

For example, sysroot is enabled in Starlark and Java (bazel). If we implement a custom C++ toolchain using unix_cc_toolchain_config.bzl as an example, removing sysroot feature will still result in --sysroot flag in compiler flags which is a bit surprising.

@iancha1992 iancha1992 added team-Rules-CPP Issues for C++ rules team-Documentation Documentation improvements that cannot be directly linked to other team labels labels Apr 16, 2024
@comius comius added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-Rules-CPP Issues for C++ rules type: feature request
Projects
None yet
Development

No branches or pull requests

4 participants