Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI tooling for patching external dependencies #22059

Closed
jgao54 opened this issue Apr 18, 2024 · 3 comments
Closed

CLI tooling for patching external dependencies #22059

jgao54 opened this issue Apr 18, 2024 · 3 comments
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request untriaged

Comments

@jgao54
Copy link

jgao54 commented Apr 18, 2024

Description of the feature request:

Similar to PNPM’s built-in pnpm patch command, it would be awesome to have the CLI tooling to support patching bazel's external dependencies.

API:
bazel patch: create a copy of the external dependency for edits
bazel patch-commit: apply the patch to the dependency
bazel patch-remove: remove the patch to the dependency

Which category does this issue belong to?

External Dependency

What underlying problem are you trying to solve with this feature?

Make a better user experience for patching external dependencies.

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Apr 18, 2024
@meteorcloudy
Copy link
Member

The MODULE.bazel file will be the source of truth for external dependencies in Bazel. It's highly unlikely we'll work on some features like this.

@meteorcloudy meteorcloudy closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
@fmeum
Copy link
Collaborator

fmeum commented Apr 23, 2024

I would say this would be very useful to have, but could very well be a separate tool built on buildozer and interacting with the BCR directly. There really isn't much benefit to building this into Bazel.

@meteorcloudy
Copy link
Member

Yeah, it'll be nice to have some toolings to prepare patch files that can be used in BCR or MODULE.bazel, and I agree it shouldn't be part of Bazel.

@jgao54 Feel free to open an issue to https://github.com/bazelbuild/buildtools

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request untriaged
Projects
None yet
Development

No branches or pull requests

6 participants