Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--output_groups can't override previous --output_groups arguments #22242

Open
Fil-Den opened this issue May 6, 2024 · 2 comments
Open

--output_groups can't override previous --output_groups arguments #22242

Fil-Den opened this issue May 6, 2024 · 2 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts type: bug

Comments

@Fil-Den
Copy link

Fil-Den commented May 6, 2024

Description of the bug:

From --output_groups documantation:
If at least one group is not prefixed, the default set of output groups is omitted.

From this, I expected that the command bazel build ... --output_groups=+foo --output_groups=bar would only produce bar files. However, in reality, both foo and bar files are created.

Can that logic be adjusted to the expected outcome?

Which category does this issue belong to?

No response

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

It can be viewed in the output groups realization:

.

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

Release 7.0.2

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@iancha1992 iancha1992 added the team-Configurability Issues for Configurability team label May 6, 2024
@gregestren gregestren added team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts and removed team-Configurability Issues for Configurability team labels May 31, 2024
@comius
Copy link
Contributor

comius commented Jun 7, 2024

The docs should say, that "If at least one group is not prefixed, the default set of output groups is omitted."

This is also the intent and behaviour of the code.

@comius comius added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed untriaged labels Jun 7, 2024
@comius
Copy link
Contributor

comius commented Jun 7, 2024

P3 to update the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts type: bug
Projects
None yet
Development

No branches or pull requests

6 participants