Linter Warning in src/main/cpp/blaze.cc for option_processor, passed by reference object

[Sittiphat]

Description of the bug:

Discovered a Google C++ Linter Warning in src/main/cpp/blaze.cc at line 1092 (see image below)

The official Google C++ guideline say that the options are to either make the reference parameter const if the parameter is not meant to be modified, or use a pointer instead of a non-const reference if the parameter is intended to be modified. Since "option_processor" is modified in the function definition, the change I believe should be opted to pass by pointer.

Which category does this issue belong to?

C++ Rules

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

No response

Which operating system are you running Bazel on?

No response

What is the output of bazel info release?

No response

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

Is this a non-const reference? If so, make const or use a pointer: OptionProcessor &option_processor cpplint(warning:runtime/references)
&option_processor

[Sittiphat]

My potential fix:
#22470

[tjgq]

The Google C++ style guide changed a few years ago, and use of pointers for input/output parameters is no longer required; non-const references are fine if the parameter is never null. See https://google.github.io/styleguide/cppguide.html#Inputs_and_Outputs.