[7.2.1] Retry on connection reset error for http cache. #22785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, it only retries when we have error whose message contains "connection reset by peer". In some cases, we could also have message like "Connection reset", e.g. https://buildkite.com/bazel/bazel-bazel-macos-ninja/builds/1827#01902690-f35a-4f3d-9166-7b39c1f885fb. PiperOrigin-RevId: 644325070 Change-Id: I75500646b35681fda25e584ec5d6ec3348cee9a5
github-actions
bot
added
awaiting-review
meteorcloudy
approved these changes
Jun 18, 2024
|
Please also send one to 7.3.0, thanks! |
Merged
via the queue into
bazelbuild:release-7.2.1
with commit Jun 18, 2024
55b48d2
33 checks passed
github-actions
bot
removed
the
awaiting-review
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Jun 25, 2024
bazelbuild/bazel#22785 fixes a bug remote caching bug that prevented us from fetching only top-level targets from cache. Enabling that option should speed up CI runs. Also increase the number of concurrent Bazel jobs, see bazelbuild/bazel#6394
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Jun 25, 2024
bazelbuild/bazel#22785 fixes a bug remote caching bug that prevented us from fetching only top-level targets from cache. Enabling that option should speed up CI runs. Also increase the number of concurrent Bazel jobs, see bazelbuild/bazel#6394
fhanau
added a commit
to cloudflare/workerd
that referenced
this pull request
Jun 26, 2024
bazelbuild/bazel#22785 fixes a bug remote caching bug that prevented us from fetching only top-level targets from cache. Enabling that option should speed up CI runs. Also increase the number of concurrent Bazel jobs, see bazelbuild/bazel#6394
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, it only retries when we have error whose message contains "connection reset by peer". In some cases, we could also have message like "Connection reset", e.g. https://buildkite.com/bazel/bazel-bazel-macos-ninja/builds/1827#01902690-f35a-4f3d-9166-7b39c1f885fb.
PiperOrigin-RevId: 644325070
Change-Id: I75500646b35681fda25e584ec5d6ec3348cee9a5