Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel client, Windows: do not use errno/strerror #2506

Closed
laszlocsomor opened this issue Feb 8, 2017 · 0 comments
Closed

Bazel client, Windows: do not use errno/strerror #2506

laszlocsomor opened this issue Feb 8, 2017 · 0 comments
Assignees
@laszlocsomor
Labels
P2 We'll consider working on this in future. (Assignee optional) platform: windows type: bug
Milestone
0.5

Comments

@laszlocsomor
Copy link
Contributor

Do not use errno in platform-independent code in the Bazel client, because it's not consistent with the POSIX standard on Windows.

Abstract it away instead like we do with GetLastErrorString.
@laszlocsomor laszlocsomor self-assigned this Feb 8, 2017
@laszlocsomor laszlocsomor added platform: windows P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug labels Feb 8, 2017
@dslomov dslomov added this to the 0.5 milestone Feb 14, 2017
@dslomov dslomov added P2 We'll consider working on this in future. (Assignee optional) and removed P3 We're not considering working on this, but happy to review a PR. (No assignee) labels Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
P2 We'll consider working on this in future. (Assignee optional) platform: windows type: bug
Projects
None yet
Milestone
0.5
Development

No branches or pull requests
2 participants
@dslomov @laszlocsomor