Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit 71c72c15 breaks Bazel on Windows #2582

Closed
laszlocsomor opened this issue Feb 24, 2017 · 3 comments
Closed

Commit 71c72c15 breaks Bazel on Windows #2582

laszlocsomor opened this issue Feb 24, 2017 · 3 comments
Assignees
@hlopko
Labels
breakage P1 I'll work on this now. (Assignee required) type: bug

Comments

@laszlocsomor
Copy link
Contributor

Description of the problem / feature request / question:

See review comment on 71c72c1

Bazel built at or after 71c72c1 doesn't work on Windows.

$ C:/tmp/Oh5NykPf/execroot/bazel2/bazel-out/local-fastbuild/bin/src/bazel.exe --output_user_root=/c/tmp5 build src:bazel --nobuild
Extracting Bazel installation...
Cannot terminate server process with PID 8428
.
ERROR: java.io.IOException: Could not read the crosstool configuration file 'CROSSTOOL file C:/tmp5/o6hbs7n0/external/local_config_cc/CROSSTOOL', because of a parser error (134:1: Expected identifier. Found '%').

If possible, provide a minimal example to reproduce the problem:

Build bazel at 6b3b8d0, it works on Windows.
Build it at 71c72c1, it gives the aforementioned error.

Environment info

  • Operating System: Windows 10
@laszlocsomor laszlocsomor added breakage P1 I'll work on this now. (Assignee required) type: bug labels Feb 24, 2017
laszlocsomor referenced this issue Feb 24, 2017
@hlopko @iirina
Fix autodetection of c++ coverage on osx
71c72c1 
Fixes #2275.

The logic that adds 'coverage' feature to the toolchain if not present in
CppConfiguration only works for linux targets. This cl teaches cc_configure.bzl
about this feature so it can be autodetected on osx correctly (although the
autodetection logic in this cl is rather naive).

--
PiperOrigin-RevId: 148336592
MOS_MIGRATED_REVID=148336592
@iirina
Copy link
Contributor

iirina commented Feb 24, 2017

Thanks @laszlocsomor for signaling this and @mhlopko for fixing!

@EvilMudkip
Copy link

I'm having an extremely similar problem, wondering what was the fix? Thanks

@hlopko
Copy link
Member

hlopko commented Sep 22, 2017

Fix was in bazel, 71c72c1. I'd suggest making sure your bazel is updated, and if the problem persists, opening a separate issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hlopko hlopko

Labels
breakage P1 I'll work on this now. (Assignee required) type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hlopko @iirina @laszlocsomor @EvilMudkip