Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel binary installer contains empty file #2662

Closed
ulfjack opened this issue Mar 10, 2017 · 6 comments
Closed

Bazel binary installer contains empty file #2662

ulfjack opened this issue Mar 10, 2017 · 6 comments
Labels
good first issue P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug
Milestone
post-1.0

Comments

@ulfjack
Copy link
Contributor

ulfjack commented Mar 10, 2017

$ unzip -l bazel-0.4.4-installer-linux-x86_64.sh
Archive: bazel-0.4.4-installer-linux-x86_64.sh
Length Date Time Name

 2714  1980-01-01 01:00   bazel
84737  1980-01-01 01:00   bazel-complete.bash

146761588 1980-01-01 01:00 bazel-real
0 1980-01-01 01:00 tools/
0 1980-01-01 01:00 tools/defaults/
0 1980-01-01 01:00 tools/defaults/BUILD

146849039 6 files
@vladmos vladmos added category: misc > bootstrap / installation P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug and removed category: misc > bootstrap / installation labels Mar 10, 2017
@damienmg
Copy link
Contributor

wow also in 0.4.5rc

@damienmg damienmg removed their assignment Mar 10, 2017
@damienmg damienmg added this to the post-1.0 milestone Mar 10, 2017
@damienmg
Copy link
Contributor

https://github.com/bazelbuild/bazel/blob/master/scripts/packages/BUILD#L83 this is because of this line that wasn't removed when we packaged the bazel_tools repository inside bazel

@harmank
Copy link
Contributor

harmank commented Mar 10, 2017 •
edited

@damienmg Should I just remove line 83 and open a pr ?

@hvardhanx
Copy link
Contributor

@harmank, I just sent a pull request for this issue.

@aljabrr
Copy link

aljabrr commented Mar 31, 2017

@Royalharsh @harmank Has the PR been merged? I could love totake on it.

@hvardhanx
Copy link
Contributor

hvardhanx commented Mar 31, 2017 •
edited

@aljabrr PR hasn't been merged yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue P3 We're not considering working on this, but happy to review a PR. (No assignee) type: bug
Projects
None yet
Milestone
post-1.0
Development

No branches or pull requests
6 participants
@vladmos @hvardhanx @damienmg @ulfjack @harmank @aljabrr