Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

//src/test/java/com/google/devtools/build/lib:remote-tests failing on Linux on CI #3348

Closed
laszlocsomor opened this issue Jul 10, 2017 · 5 comments
Assignees
Labels
breakage P1 I'll work on this now. (Assignee required)

Comments

@laszlocsomor
Copy link
Contributor

laszlocsomor commented Jul 10, 2017

http://ci.bazel.io/view/Dashboard/job/bazel-tests/BAZEL_VERSION=HEAD,PLATFORM_NAME=linux-x86_64/867/console

INFO: Discarding analysis cache: configurations have changed.
........E..................................................
Time: 27.127
There was 1 failure:
1) sameBlobShouldNotBeUploadedTwice(com.google.devtools.build.lib.remote.ByteStreamUploaderTest)
java.lang.AssertionError: Not true that <com.google.common.util.concurrent.SettableFuture@275a3d2f> is the same instance as <com.google.common.util.concurrent.SettableFuture@510d214>
	at com.google.devtools.build.lib.remote.ByteStreamUploaderTest.sameBlobShouldNotBeUploadedTwice(ByteStreamUploaderTest.java:302)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.junit.internal.runners.statements.FailOnTimeout$StatementThread.run(FailOnTimeout.java:74)
Caused by: java.lang.AssertionError: Not true that <com.google.common.util.concurrent.SettableFuture@275a3d2f> is the same instance as <com.google.common.util.concurrent.SettableFuture@510d214>
	at com.google.common.truth.FailureStrategy.fail(FailureStrategy.java:28)
	at com.google.common.truth.FailureStrategy.fail(FailureStrategy.java:22)
	at com.google.common.truth.Subject.failComparingToStrings(Subject.java:348)
	at com.google.common.truth.Subject.isSameAs(Subject.java:153)
	... 10 more

FAILURES!!!
Tests run: 80,  Failures: 1
@laszlocsomor
Copy link
Contributor Author

Attempting to repro locally.

@laszlocsomor laszlocsomor added breakage P1 I'll work on this now. (Assignee required) under investigation labels Jul 10, 2017
@laszlocsomor
Copy link
Contributor Author

Culprit: dc24004

@laszlocsomor
Copy link
Contributor Author

@buchgr : I can repro this with bazel 0.5.2 on Linux

@laszlocsomor laszlocsomor changed the title //src/test/java/com/google/devtools/build/lib:remote-tests failing on CI //src/test/java/com/google/devtools/build/lib:remote-tests failing on Linux on CI Jul 10, 2017
@buchgr
Copy link
Contributor

buchgr commented Jul 10, 2017

Looking ...

@buchgr
Copy link
Contributor

buchgr commented Jul 10, 2017

I can't repo the failure, but I can see that it's theoretically possible. Working on a fix. Note that the test has a race, but the code seems fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakage P1 I'll work on this now. (Assignee required)
Projects
None yet
Development

No branches or pull requests

2 participants