Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows tests: failure to auto-conf if there is an equal on the workspace path #3442

Closed
damienmg opened this issue Jul 24, 2017 · 4 comments
Closed
Assignees
Labels
breakage P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions

Comments

@damienmg
Copy link
Contributor

Repro: test bazel with an equal sign in the workspace path, like in CI: http://ci.bazel.io/job/Global/job/bazel-tests/108/testReport/junit/(root)/(empty)/test_java/

Results:
____Loading package: @local_jdk//
ERROR: in target '//external:cc_toolchain': no such package '@local_config_cc//': Traceback (most recent call last):
File "C:/temp/2104286f1ce1b1c5200886c360f7e20d/root/nf5aby06/external/bazel_tools/tools/cpp/cc_configure.bzl", line 32
configure_windows_toolchain(repository_ctx)
File "C:/temp/2104286f1ce1b1c5200886c360f7e20d/root/nf5aby06/external/bazel_tools/tools/cpp/windows_cc_configure.bzl", line 316, in configure_windows_toolchain
_find_env_vars(repository_ctx, vc_path)
File "C:/temp/2104286f1ce1b1c5200886c360f7e20d/root/nf5aby06/external/bazel_tools/tools/cpp/windows_cc_configure.bzl", line 202, in _find_env_vars
(key, value) = env.split("=")
lvalue has length 2, but rvalue has has length 3.
____Elapsed time: 2.260s

/cc @buchgr

@meteorcloudy
Copy link
Member

What equal sign? Where can I find it?

@damienmg
Copy link
Contributor Author

Oh sorry did not copy it but the equals was on the test setup path, ands split cut on all equals, splitting only on the first one should fix the issue

@damienmg
Copy link
Contributor Author

@meteorcloudy
Copy link
Member

Thanks! I'll send a fix.

@aiuto aiuto added team-Configurability platforms, toolchains, cquery, select(), config transitions and removed team-Configurability platforms, toolchains, cquery, select(), config transitions z-category: extensibility > configurability labels Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breakage P1 I'll work on this now. (Assignee required) team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Development

No branches or pull requests

3 participants