Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel client, Windows, regression: can't create top-level directories #3454

Closed
laszlocsomor opened this issue Jul 26, 2017 · 3 comments
Closed

Bazel client, Windows, regression: can't create top-level directories #3454

laszlocsomor opened this issue Jul 26, 2017 · 3 comments
Assignees
@laszlocsomor
Labels
P2 We'll consider working on this in future. (Assignee optional) platform: windows type: bug

Comments

@laszlocsomor
Copy link
Contributor

b69acfa introduced a regression: blaze_util::MakeDirectoryW computes the parent of "\\?\C:\foo" to be "\\?\C:" (no trailing backslash) and blaze_util::IsRootDirectory doesn't recognize this as a root directory, so we attempt to create its parent, which is computed to be "\\?".
@laszlocsomor laszlocsomor self-assigned this Jul 26, 2017
@laszlocsomor laszlocsomor added platform: windows P1 I'll work on this now. (Assignee required) Release blocker type: bug labels Jul 26, 2017
@laszlocsomor
Copy link
Contributor Author

@buchgr : FYI

@buchgr
Copy link
Contributor

buchgr commented Jul 26, 2017

Thanks :-) Let me know once you have a fix.

@damienmg
Copy link
Contributor

The commit is not in the release branch so it is not blocking 0.5.3

@laszlocsomor laszlocsomor added P2 We'll consider working on this in future. (Assignee optional) and removed Release blocker P1 I'll work on this now. (Assignee required) labels Jul 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laszlocsomor laszlocsomor

Labels
P2 We'll consider working on this in future. (Assignee optional) platform: windows type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@buchgr @damienmg @laszlocsomor