Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

launcher_test is failing on windows #3620

Closed
damienmg opened this issue Aug 25, 2017 · 8 comments
Closed

launcher_test is failing on windows #3620

damienmg opened this issue Aug 25, 2017 · 8 comments
Assignees
@meteorcloudy
Labels
breakage P1 I'll work on this now. (Assignee required) platform: windows type: bug under investigation

Comments

@damienmg
Copy link
Contributor

http://ci.bazel.io/job/bazel-tests/982/testReport/junit/src_test_py_bazel_launcher_test/cmd/src_test_py_bazel_launcher_test_cmd/
@damienmg
Copy link
Contributor Author

Not flaky sorry

@damienmg damienmg changed the title launcher_test is flaky on windows launcher_test is failing on windows Aug 25, 2017
@damienmg damienmg mentioned this issue Aug 25, 2017
Closed
@damienmg
Copy link
Contributor Author

It actually make tests fail on windows with bazel @ HEAD too

@laszlocsomor
Copy link
Contributor

Looking.

@damienmg
Copy link
Contributor Author

Suspecting 54c5c5c sorry I though native launcher was your work. /cc @meteorcloudy

@laszlocsomor
Copy link
Contributor

I can repro locally with 0.5.4, at f6291af.

@laszlocsomor
Copy link
Contributor

I confirmed that 54c5c5c is the culprit.

@meteorcloudy
Copy link
Member

I have a simple fix for this

@meteorcloudy
Copy link
Member

Sorry for the breakage, I didn't run the test after changing in internal review.
Maybe add launcher_test in Kokoro as well?

@ianthehat ianthehat mentioned this issue Sep 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@meteorcloudy meteorcloudy

Labels
breakage P1 I'll work on this now. (Assignee required) platform: windows type: bug under investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@damienmg @meteorcloudy @laszlocsomor