Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated file_provider #6088

Open
c-parsons opened this issue Sep 5, 2018 · 3 comments
Open

Remove deprecated file_provider #6088

c-parsons opened this issue Sep 5, 2018 · 3 comments
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts

Comments

@c-parsons
Copy link
Contributor

file_provider has been around for some time, but is almost completely undocumented.

Instead of rushing to document it, we are considering deprecating it as part of the "Fixing Starlark Rule Outputs" document sent to bazel-dev.

This will track following up specifically making a commitment to deprecate or document file_provider.

@c-parsons c-parsons self-assigned this Sep 5, 2018
@jin
Copy link
Member

jin commented Jan 14, 2019

could you add a priority to this issue, please?

@laurentlb laurentlb added type: documentation (cleanup) P2 We'll consider working on this in future. (Assignee optional) labels Jan 17, 2019
@laurentlb
Copy link
Contributor

Any update about the next steps?

@c-parsons
Copy link
Contributor Author

We've made no additional commitment to remove file_provider as part of the rule outputs cleanup.

Most users shouldn't need to use this provider, and can use DefaultInfo instead. The only place this is used instead of DefaultInfo seems to be in Android rules.

@brandjon brandjon added P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) team-Build-Language and removed P2 We'll consider working on this in future. (Assignee optional) team-Starlark labels Feb 17, 2021
@brandjon brandjon added untriaged team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts and removed team-Build-Language labels Nov 4, 2022
@sgowroji sgowroji added the team-Documentation Documentation improvements that cannot be directly linked to other team labels label Jan 11, 2023
@comius comius changed the title Starlark's file_provider is undocumented Remove deprecated file_provider Aug 28, 2023
@comius comius added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed type: documentation (cleanup) P4 This is either out of scope or we don't have bandwidth to review a PR. (No assignee) untriaged team-Documentation Documentation improvements that cannot be directly linked to other team labels labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts
Projects
None yet
Development

No branches or pull requests

6 participants