Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels as tool_path in CROSSTOOL #7642

Closed
excitoon opened this issue Mar 6, 2019 · 8 comments
Closed

Labels as tool_path in CROSSTOOL #7642

excitoon opened this issue Mar 6, 2019 · 8 comments
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules

Comments

@excitoon
Copy link
Contributor

excitoon commented Mar 6, 2019

Can we have a possibility to specify Labels as tool_path in CROSSTOOL's (possibly even being compiled in the same build)? That would be a great step towards hermeticness.

E.g.:

  tool_path: "@some_gcc//:bin/gcc"
@silvergasp
Copy link
Contributor

As of bazel 0.23.0 CROSSTOOL is deprecated in favour of skylark cc_toolchain and cc_common.create_cc_toolchain_config_info. See here. However the same problem persists in the new implementation i.e.

tool_path(
    name = "gcc",
    path = "@some_gcc//bin:gcc",
),

Is not possible.

I would perhaps recommend editing the CROSSTOOL title to this issue to match the new toolchain skylark api, as it is more likely to receive support.

@silvergasp
Copy link
Contributor

I am also interested in a fix or a workaround for this. I would be happy to create a more up to date descriptive issue if that were ok with you?

@excitoon
Copy link
Contributor Author

Sure. I can not edit title from phone unfortunately.

@silvergasp
Copy link
Contributor

I have added a new issue here #7746. If this doesn't cover your use case I'd keep this issue open.

@kada-zaouak
Copy link

[``](**###

#7046

**)

@kada-zaouak
Copy link

#700#

@jin jin added team-Rules-CPP Issues for C++ rules untriaged labels Mar 25, 2019
@scentini scentini added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Mar 28, 2019
@scentini
Copy link
Contributor

cc/ @hlopko

@hlopko
Copy link
Member

hlopko commented Mar 29, 2019

Hi all, let's continue the discussion in #7746. Thanks!

@hlopko hlopko closed this as completed Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 We'll consider working on this in future. (Assignee optional) team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

No branches or pull requests

6 participants