-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add manifest_values to android library rules #8808
Comments
I found a possible workaround for this issue.
Sample code below is released under the GPL-3 license: Copyright (C) 2019 Dror Smolarsky This program is free software: you can redistribute it and/or modify // #############################################################3 py_binary( // #############################################################3 import argparse class InvalidArgumentError(Exception): def parse_manifest_values_arg(manifest_values_arg):
def write_manifest(manifest_values): if 'main' == name: // #############################################################3 load("@io_bazel_rules_kotlin//kotlin:kotlin.bzl", "kt_android_library") def _xkv_android_manifest_values(name, version): def _xkv_android_manifest_values_rule_impl(ctx):
//# Rule to get Android manifest values variable def xkv_android_library(name, version, **kwargs):
def xkv_android_kt_library(name, version, **kwargs):
// ###################################################### load("@rules_jvm_external//:defs.bzl", "artifact") xkv_android_kt_library( |
Thank you for contributing to the Bazel repository! This issue has been marked as stale since it has not had any activity in the last 3 years. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-bazeler". Please reach out to the triage team ( |
This issue has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team ( |
Description of the problem / feature request:
Currently android library rules do not have the manifest_values argument.
This makes it harder to enforce things such as minSdkVersion and targetSdkVersion for all
projects under a workspace, since each library has to have the min and target SDKs defined
separately in the manifest file.
Feature requests: what underlying problem are you trying to solve with this feature?
Use common minSdkVersion and targetSdkVersion for all android packages in a workspace.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
NA
What operating system are you running Bazel on?
Windows & Linux
What's the output of
bazel info release
?release 0.27.0
If
bazel info release
returns "development version" or "(@non-git)", tell us how you built Bazel.NA
What's the output of
git remote get-url origin ; git rev-parse master ; git rev-parse HEAD
?NA.
Have you found anything relevant by searching the web?
No
Any other information, logs, or outputs that you want to share?
NA
The text was updated successfully, but these errors were encountered: