Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify where repository rules should be defined #8941

Open
mboes opened this issue Jul 20, 2019 · 0 comments
Open

Clarify where repository rules should be defined #8941

mboes opened this issue Jul 20, 2019 · 0 comments
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: documentation (cleanup)

Comments

@mboes
Copy link
Contributor

mboes commented Jul 20, 2019

Description of the feature request:

Add wording in the Bazel rule deployment guidelines clarifying where repository rules should be defined: defs.bzl, repositories.bzl or elsewhere?

Feature requests: what underlying problem are you trying to solve with this feature?

Currently, the documentation says "rules" should be exposed in defs.bzl. There is a section titled "Repository rules", which one would expect says what to do about repository rules, but it only discusses introducing a single macro that defines all necessary dependencies. If I have a set of rules called rules_foo, which perhaps has a few build rules and several repository rules, it's unclear where the user should expect to find all the repository rules.

@jin jin added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: documentation (cleanup) untriaged labels Jul 22, 2019
@laurentlb laurentlb added P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Jul 24, 2019
@philwo philwo added the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Jun 15, 2020
@philwo philwo added P3 We're not considering working on this, but happy to review a PR. (No assignee) and removed P2 We'll consider working on this in future. (Assignee optional) labels Dec 8, 2020
@philwo philwo removed the team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website label Nov 29, 2021
@ShreeM01 ShreeM01 added the team-Documentation Documentation improvements that cannot be directly linked to other team labels label Dec 5, 2022
@keertk keertk added the help wanted Someone outside the Bazel team could own this label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Someone outside the Bazel team could own this P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Documentation Documentation improvements that cannot be directly linked to other team labels team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: documentation (cleanup)
Projects
None yet
Development

No branches or pull requests

6 participants