New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use skylib in runfiles example #182

Closed

ashi009 opened this issue Aug 20, 2020 · 1 comment

ashi009 commented Aug 20, 2020

There are lots of path concatenation in this example. Using skylib for this purpose is a much better practice.

https://github.com/bazelbuild/bazel-skylib/blob/dc080e95161964a1ff841bfd0b871a1123c027a8/lib/paths.bzl#L237

Collaborator

alexeagle commented Oct 30, 2023

I only see a small amount of this in tool.bzl, so I don't think it's a big enough problem to warrant anyone's time.

alexeagle closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment