Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary computations in the sync process #5217

Closed
idanakav opened this issue Aug 8, 2023 · 0 comments
Closed

Unnecessary computations in the sync process #5217

idanakav opened this issue Aug 8, 2023 · 0 comments
Assignees
Labels
awaiting-maintainer Awaiting review from Bazel team on issues topic: sync Issues related to the sync operation type: bug

Comments

@idanakav
Copy link
Contributor

idanakav commented Aug 8, 2023

The issue will outline a few low hanging fruits in the sync process that can help optimizing the incremental sync times in the plugin.

  1. WorkingSet computation can be skipped if expand to working set is disabled, computed 3 times per incremental sync.
    Avoiding this computation can reduce sync times by roughly 3x git diff durations.

  2. BazelInfo is computed 5 times during a incremental sync, with no caching involved.
    Avoiding this computation can reduce sync times by roughly 5x bazel info durations.

For the Bazel info case, the idea is to cache the result and invalidate once needed, for example in a bazel sync error, alternatively, if that would be too tricky or error prone, we can proceed with computing it only once per sync.

@idanakav idanakav added awaiting-maintainer Awaiting review from Bazel team on issues type: bug labels Aug 8, 2023
@Pavank1992 Pavank1992 added the topic: sync Issues related to the sync operation label Aug 9, 2023
@Pavank1992 Pavank1992 assigned mai93 and unassigned sgowroji, Pavank1992 and iancha1992 Aug 9, 2023
@mai93 mai93 assigned tpasternak and blorente and unassigned mai93 Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-maintainer Awaiting review from Bazel team on issues topic: sync Issues related to the sync operation type: bug
Projects
Development

No branches or pull requests

7 participants